WIP: report: configure features

[connorjclark]

Configuration might be useful?

no impact on the devtools integration (it overrides some printing stuff which probably shouldn't be configurable)

the PSI integration would benefit slightly

[paulirish]

if this file was ESM, then we could just export the setupElemScreenshots method? would that be equivalent?

[paulirish]

is the idea that a devtools rendering config would have toggleDarkMode: false (instead of this isDevTools()) ?

[connorjclark]

didnt consider that but ya, sure

[paulirish]

driveby: this fn should be renamed to applyNarrowClassSometimes or something

[connorjclark]

if this file was ESM, then we could just export the setupElemScreenshots method? would that be equivalent?

Ignoring the unsolved problem of us using ESM... I suppose? Although I prefer this method (shoving the entire interface into an options object) vs. making arbitrary methods "public".

[brendankenny]

/**
 * @typedef FeatureSet
 * @property {boolean} dropDownMenu
 * @property {boolean | {containerEl: Element}} elementScreenshotOverlay
 * @property {boolean} fireworks
 * @property {boolean} i18n
 * @property {boolean} mediaQueryListeners
 * @property {boolean} printing
 * @property {boolean} showMetricDescriptionsOnError
 * @property {boolean} stickyHeader
 * @property {boolean} thirdPartyFilter
 * @property {boolean} toggleDarkMode
 */

what of these features is PSI likely to end up using?

[connorjclark]

I think these would be desirable:

• elementScreenshotOverlay (already in effect)
• showMetricDescriptionsOnError
• thirdPartyFilter

Fireworks would be cool, but understandable to avoid :)

@exterkamp wdyt?

[connorjclark]

Shane agreed with the three features I listed above.

[connorjclark]

also: should move this._saveGistCallback from Viewer features to base features, so that DevTools can use it (if we figure out how to postMessage...)

[brendankenny]

the download, opening, then saving is unfortunate, but saving a gist requires having github sign in, so I'm not sure if that's ever going to work in devtools

[connorjclark]

closing for #12254