core(fr): add fetcher to transitional driver #12419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Apr 28, 2021
lighthouse-core/gather/fetcher.js
Outdated
| */ | ||
| constructor(driver) { | ||
| this.driver = driver; | ||
| this.session = driver.defaultSession; |
There was a problem hiding this comment.
FWIW could avoid the sticky issue of the other properties being ready/demanding a particular initialization order by saving this._driver = driver instead, not a big deal though
patrickhulce
suggested changes
Apr 28, 2021
There was a problem hiding this comment.
er, actually I think I feel strongly enough about https://github.com/GoogleChrome/lighthouse/pull/12419/files#r622408557 to have a discussion about it at least before approval :)
|
I didn't feel very strongly, thought #12419 (comment) was a good idea. |
patrickhulce
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the robots.txt gatherer compatible with CSPs we should use the new fetcher. This PR makes fetcher available to FR gatherers.
Related
#10225