core: fix main session OOPIF checks for devtools #12533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
May 21, 2021
adamraine
approved these changes
May 21, 2021
| // Many places in Lighthouse use `record.sessionId === undefined` to mean that the session is not | ||
| // an OOPIF. To maintain this property, we intercept sessionId here and set it to undefined if | ||
| // it matches the first value seen. | ||
| if (this._mainSessionId === null) { |
There was a problem hiding this comment.
I wish the roles of undefined and null are reversed for _mainSessionId, but doing so would probably require changes to the protocol and/or large changes to how we handle sessionId downstream. Sounds like a lot of work for a minor annoyance, so this LGTM.
There was a problem hiding this comment.
we'll need to take another look at the entire use of sessionId when we revisit FR OOPIF handling which is going to have to be more complex anyway. I'm also fine with a temporary bandaid here
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in DevTools that no source map contents were being used: so no subRows in unused-javascript with module-level coverage, and no bundle in script-treemap-data.
JSBundles had errored
sizesbecausescriptElement.contentwas null:This property is set for external scripts in a post-processing step in ScriptElements:
In DevTools, the OOPIF check filtered out all records because
sessionIdis set even for the main protocol connection. This is due to a complication introduced while adding multi-client support. See https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2607769 for more. I failed to followup on that, and we have no tests touching OOPIF checks in devtools tests, so it went unnoticed.This PR is a possible workaround/bandaid. I manually verified with
yarn open-devtoolsthat JSBundlessizesproperty is set correctly, and all the audits are correctly processing module information. I'll look into adding tests too.