Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: make metric filter tab accessible #12552

Merged
merged 1 commit into from May 25, 2021
Merged

report: make metric filter tab accessible #12552

merged 1 commit into from May 25, 2021

Conversation

connorjclark
Copy link
Collaborator

fixes #12501

I did the same thing as here: #12495

@connorjclark connorjclark requested a review from a team as a code owner May 24, 2021 20:34
@connorjclark connorjclark requested review from adamraine and removed request for a team May 24, 2021 20:34
@google-cla google-cla bot added the cla: yes label May 24, 2021
@brendankenny brendankenny assigned paulirish and unassigned adamraine May 24, 2021
paulirish
paulirish approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels good. looked in both safari and firefox, too.

@paulirish paulirish merged commit 836fd19 into master May 25, 2021
@paulirish paulirish deleted the report-metric-kb branch May 25, 2021 20:54
@connorjclark connorjclark mentioned this pull request Jul 21, 2021
Merged
@ryan-ally ryan-ally mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@adamraine adamraine Awaiting requested review from adamraine

Assignees

@paulirish paulirish

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metric filter buttons need focus-visible / tabbing support
4 participants
@connorjclark @paulirish @adamraine @devtools-bot