Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run axe tests that we have audits for #1257

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Only run axe tests that we have audits for #1257

merged 1 commit into from
Dec 30, 2016

Conversation

robdodson
Copy link
Contributor

Switch to the new axe.run method which returns a promise. Now we're only running the tests that we actually audit for, instead of running the default entire axe suite. Also cleaned up a duplicate smoke test and improved the description of the aria-allowed-attr audit a bit.

runOnly: {
type: 'rule',
values: [
'aria-allowed-attr',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this list worth automating? It's relatively small right now, but will require us to (remember to) update it every time there's a new audit. There's already a lot of things to check off the list when adding a new audit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah there are actually predefined rulesets we could use, for instance, run all the rules required for WCAG A:

{
  runOnly: {
      type: "tag",
      values: ["wcag2a"]
    }
}

I would like to actually move over to doing that as the next step. But I think that will also require reworking the audits and tests a bit. So before doing that I thought it might be nice to just make lighthouse do less work in the meantime.

@ebidel ebidel merged commit 22ddf2f into master Dec 30, 2016
@ebidel ebidel deleted the a11y-trim branch December 30, 2016 21:34
@ebidel
Copy link
Contributor

ebidel commented Dec 30, 2016

💥

@paulirish
Copy link
Member

This is fab. Thanks @robdodson !

andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants