Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: npmignore larger unnecessary files #12627

Merged
merged 1 commit into from Jun 25, 2021
Merged

misc: npmignore larger unnecessary files #12627

merged 1 commit into from Jun 25, 2021

Conversation

brendankenny
Copy link
Member

going through our npm packed files, a few more large ones jumped out that aren't needed for a production run (basically all the files >100KiB that aren't a locale file):

  • one of the recipes under docs/
  • prebuilt json schemas under sd-validation/
  • our 360KiB (and growing) changelog

npmignoring these saves about 1MiB in our installed package size (package size: 2.5 MB -> 2.2 MB, unpacked size: 12.6 MB -> 11.6 MB).

I never go into an installed package to get docs about that package (I go to npm or direct to the repo), but if that is a use case worth preserving we could ignore just docs/recipes/ and keep the changelog and still get like half of the savings.

@brendankenny brendankenny requested a review from a team as a code owner June 7, 2021 22:39
@brendankenny brendankenny requested review from connorjclark and removed request for a team June 7, 2021 22:39
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
@brendankenny
Copy link
Member Author

ping @connorjclark :)

@brendankenny brendankenny merged commit dbdc6a7 into master Jun 25, 2021
@brendankenny brendankenny deleted the ignore-smore branch June 25, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants