Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(config): keep full-page-screenshot in skipAudits case #12645

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

paulirish
Copy link
Member

We already had special handling of f-p-s w/ onlyCategories (#11829) but it makes sense to do the same for skipAudits.

fixes #11913
fixes #12642

@paulirish paulirish requested a review from a team as a code owner June 9, 2021 23:44
@paulirish paulirish requested review from connorjclark and removed request for a team June 9, 2021 23:44
@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@connorjclark connorjclark merged commit 4aea3d7 into master Aug 16, 2021
@connorjclark connorjclark deleted the configfps-skip branch August 16, 2021 21:28
@alekseykulikov
Copy link
Contributor

Thank you @paulirish 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skipAudits disables full-page-screenshot gatherer --skip-audits flag excludes full-page-screenshot
4 participants