core(preload): temporarily disable all preload advice #12661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you summarize AIs needed for v9 in the tracker? #12614 |
Done 👍 |
|
friendly ping @adamraine :) |
adamraine
approved these changes
Jun 22, 2021
Comment on lines
-6417
to
-6422
| { | ||
| "startTime": 0, | ||
| "name": "lh:computed:LanternLargestContentfulPaint", | ||
| "duration": 100, | ||
| "entryType": "measure" | ||
| }, |
There was a problem hiding this comment.
Were we making an extra call to this that we didn't need to?
There was a problem hiding this comment.
No, it was necessary. The preload LCP image audit makes an explicit lantern LCP request in order to get the LCP graph but our sample results here uses observed metrics for LCP itself which never requests the lantern computed artifact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily moves all our preload audits to always return
notApplicablewhile the preload fix is being evaluated. See #11960 for long-term plan and more discussion.Related Issues/PRs
ref #11960
FYI @khempenius @addyosmani @spanicker