Add "minimal-ui" as an allowed display value. #1268
Conversation
dracos
force-pushed
the
minimal-display
branch
from
36b8e62
to
fda76bf
Compare
dracos
changed the title
Commit 98c4980 said "manifest display must be one of the 3 allowed values.", and this adds the fourth allowed value.
dracos
force-pushed
the
minimal-display
branch
from
fda76bf
to
f508d1e
Compare
|
Could you add the value to the test-case as well |
|
Done, sorry for missing. |
| @@ -37,7 +37,8 @@ class ManifestDisplay extends Audit { | |||
| * @return {boolean} | |||
| */ | |||
| static hasRecommendedValue(val) { | |||
| return (val === 'fullscreen' || val === 'standalone' || val === 'browser'); | |||
| return (val === 'fullscreen' || val === 'standalone' || | |||
There was a problem hiding this comment.
This could be: ['browser', 'fullscreen', 'minimal-ui', 'standalone'].indexOf(val) !== -1;
|
Giving this to @paulirish for comment. |
| @@ -37,7 +37,8 @@ class ManifestDisplay extends Audit { | |||
| * @return {boolean} | |||
| */ | |||
| static hasRecommendedValue(val) { | |||
| return (val === 'fullscreen' || val === 'standalone' || val === 'browser'); | |||
| return (val === 'fullscreen' || val === 'standalone' || | |||
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Wait, so what is the purpose of this audit now? This passes on all possible values of |
|
This audit is in "Other" and not part of the PWA test. It's a soft audit on correctness of your manifest. We haven't been using a "standalone" audit for PWA-ness for a while now. |
|
Right, it was testing poorly before, so I guess you could argue this at least makes it do nothing consistently :) I just mean the only way to fail this audit now is to not have a manifest at all. Do we still need it? |
* Add "minimal-ui" as an allowed display value. Commit 98c4980 said "manifest display must be one of the 3 allowed values.", and this adds the fourth allowed value. * Adopt style suggested by Eric
Commit 98c4980 said "manifest display must be one of the 3 allowed values.", and this adds the fourth allowed value. For #495.