Removes hash fragments from url in offline audit

lighthouse-core/gather/gatherers/offline.js

@@ -17,6 +17,7 @@
 'use strict';
 
 const Gatherer = require('./gatherer');
+const URL = require('../../lib/url-shim');
 
 class Offline extends Gatherer {
   beforePass(options) {
@@ -25,7 +26,8 @@ class Offline extends Gatherer {
 
   afterPass(options, tracingData) {
     const navigationRecord = tracingData.networkRecords.filter(record => {
-      return record._url === options.url && record._fetchedViaServiceWorker;
+      return URL.equalWithExcludedFragments(record._url, options.url) &&
+        record._fetchedViaServiceWorker;
     }).pop(); // Take the last record that matches.
 
     return options.driver.goOnline(options).then(_ => {

lighthouse-core/lib/url-shim.js

@@ -57,7 +57,6 @@ URL.hostsMatch = function hostsMatch(urlA, urlB) {
   }
 };
 
-
 /**
  * @param {string} url
  * @return {string}
@@ -95,4 +94,20 @@ URL.getDisplayName = function getDisplayName(url) {
   return name;
 };
 
+/**
+ * Determine if url1 equals url2, ignoring URL fragments.
+ * @param {string} url1
+ * @param {string} url2
+ * @return {boolean}
+ */
+URL.equalWithExcludedFragments = function(url1, url2) {
+  url1 = new URL(url1);
+  url1.hash = '';
+
+  url2 = new URL(url2);
+  url2.hash = '';
+
+  return url1.href === url2.href;
+};
+
 module.exports = URL;

lighthouse-core/test/gather/gatherers/offline-test.js

@@ -37,9 +37,19 @@ describe('Offline gatherer', () => {
       url: 'https://do-not-match.com/',
       driver: mockDriver
     };
-    return offlineGather.afterPass(options, tracingData).then(artifact => {
-      assert.strictEqual(artifact, -1);
-    });
+    const optionsWithQueryString = {
+      url: 'https://ifixit-pwa.appspot.com/?history',
+      driver: mockDriver
+    };
+
+    return Promise.all([
+      offlineGather.afterPass(options, tracingData).then(artifact => {
+        assert.strictEqual(artifact, -1);
+      }),
+      offlineGather.afterPass(optionsWithQueryString, tracingData).then(artifact => {
+        assert.strictEqual(artifact, -1);
+      }),
+    ]);
   });
 
   it('returns an artifact set to 200 when offline loading succeeds', () => {
@@ -48,8 +58,17 @@ describe('Offline gatherer', () => {
       url: 'https://ifixit-pwa.appspot.com/',
       driver: mockDriver
     };
-    return offlineGather.afterPass(options, tracingData).then(artifact => {
-      assert.strictEqual(artifact, 200);
-    });
+    const optionsWithFragment = {
+      url: 'https://ifixit-pwa.appspot.com/#/history',
+      driver: mockDriver
+    };
+    return Promise.all([
+      offlineGather.afterPass(options, tracingData).then(artifact => {
+        assert.strictEqual(artifact, 200);
+      }),
+      offlineGather.afterPass(optionsWithFragment, tracingData).then(artifact => {
+        assert.strictEqual(artifact, 200);
+      }),
+    ]);
   });
 });