report: make denser. changes to typography, group descriptions, more #13249
Conversation
|
Some issues with category fractions:
|
|
Edit: Looks like this is an existing issue, I'll look into it. We still want these metrics to be full width right?
|
paulirish
force-pushed
the
report-polish-and-group-desc-move
branch
from
a1d3ca5
to
e33600e
Compare
report/assets/styles.css
Outdated
| --color-teal-600: #00897B; | ||
| --color-white: #FFFFFF; | ||
|
|
||
| /* Context-specific colors */ | ||
| --color-average-secondary: var(--color-orange-700); | ||
| --color-average: var(--color-orange); | ||
| --color-average-text: #C33300; |
There was a problem hiding this comment.
jiwoong selected this instead.
Yup. Known issue. |
|
Moa stuff I found Some links are missing the correct color:
Also warning text has color contrast issues
|
report/assets/styles.css
Outdated
| @@ -1025,14 +975,15 @@ | |||
| color: var(--color-red-700); | |||
| } | |||
|
|
|||
|
|
|||
|
|
||
|
|
||
| details .lh-clump-toggle::before {content: 'Show';} | ||
| details[open] .lh-clump-toggle::before {content: 'Hide';} |
There was a problem hiding this comment.
Some more strings that could be localized here
There was a problem hiding this comment.
pulled into separate PR #13308
| @@ -1820,20 +1786,23 @@ | |||
|
|
|||
|
|
|||
| .lh-meta__items { | |||
| --meta-icon-size: calc(var(--report-icon-size) * 0.667); | |||
There was a problem hiding this comment.
Does this need to be full width? I kinda liked it when it was narrower + centered.
| @@ -1153,9 +1081,13 @@ | |||
|
|
|||
| .lh-warnings { | |||
| --item-margin: calc(var(--report-line-height) / 6); | |||
There was a problem hiding this comment.
This is also takes up the full width where it didn't before.
Quite a few changes in here. I've been iterating with jiwoong over the past week.
Currently draft, but will probably flip in a few.