core(fcp): handle negative request endTime
#13452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Dec 1, 2021
| {"url": "https://m.mop.com/", "roughEstimateOfFCP": 2609, "optimisticFCP": 2609, "pessimisticFCP": 2609, "roughEstimateOfFMP": 2609, "optimisticFMP": 2609, "pessimisticFMP": 2609, "roughEstimateOfTTI": 6501, "optimisticTTI": 4855, "pessimisticTTI": 8147, "roughEstimateOfSI": 6197, "optimisticSI": 2399, "pessimisticSI": 4751, "roughEstimateOfLCP": 3537, "optimisticLCP": 3387, "pessimisticLCP": 3687}, | ||
| {"url": "https://m.sogou.com/", "roughEstimateOfFCP": 2149, "optimisticFCP": 2149, "pessimisticFCP": 2149, "roughEstimateOfFMP": 3074, "optimisticFMP": 2149, "pessimisticFMP": 3999, "roughEstimateOfTTI": 4477, "optimisticTTI": 4198, "pessimisticTTI": 4756, "roughEstimateOfSI": 8381, "optimisticSI": 4734, "pessimisticSI": 3082, "roughEstimateOfLCP": 5287, "optimisticLCP": 4935, "pessimisticLCP": 5638}, | ||
| {"url": "https://m.youdao.com/", "roughEstimateOfFCP": 1497, "optimisticFCP": 1497, "pessimisticFCP": 1497, "roughEstimateOfFMP": 1497, "optimisticFMP": 1497, "pessimisticFMP": 1497, "roughEstimateOfTTI": 2491, "optimisticTTI": 2348, "pessimisticTTI": 2634, "roughEstimateOfSI": 2371, "optimisticSI": 1152, "pessimisticSI": 1552, "roughEstimateOfLCP": 2304, "optimisticLCP": 2304, "pessimisticLCP": 2304}, | ||
| {"url": "https://mail.ru/", "roughEstimateOfFCP": 3560, "optimisticFCP": 3560, "pessimisticFCP": 3560, "roughEstimateOfFMP": 3560, "optimisticFMP": 3560, "pessimisticFMP": 3560, "roughEstimateOfTTI": 25870, "optimisticTTI": 19843, "pessimisticTTI": 31897, "roughEstimateOfSI": 9640, "optimisticSI": 2087, "pessimisticSI": 10719, "roughEstimateOfLCP": 4873, "optimisticLCP": 4727, "pessimisticLCP": 5018}, |
There was a problem hiding this comment.
Callout for updated LCP values on this site
| {"url": "https://www.linkedin.com/", "roughEstimateOfFCP": 1903, "optimisticFCP": 1903, "pessimisticFCP": 1903, "roughEstimateOfFMP": 1903, "optimisticFMP": 1903, "pessimisticFMP": 1903, "roughEstimateOfTTI": 11440, "optimisticTTI": 9843, "pessimisticTTI": 13037, "roughEstimateOfSI": 2073, "optimisticSI": 655, "pessimisticSI": 2164, "roughEstimateOfLCP": 2196, "optimisticLCP": 2155, "pessimisticLCP": 2237}, | ||
| {"url": "https://www.metacafe.com/", "roughEstimateOfFCP": 1900, "optimisticFCP": 1900, "pessimisticFCP": 1900, "roughEstimateOfFMP": 1900, "optimisticFMP": 1900, "pessimisticFMP": 1900, "roughEstimateOfTTI": 6467, "optimisticTTI": 5990, "pessimisticTTI": 6943, "roughEstimateOfSI": 3513, "optimisticSI": 769, "pessimisticSI": 4134, "roughEstimateOfLCP": 5198, "optimisticLCP": 5198, "pessimisticLCP": 5198}, | ||
| {"url": "https://www.mgid.com/ru", "roughEstimateOfFCP": 2164, "optimisticFCP": 2164, "pessimisticFCP": 2164, "roughEstimateOfFMP": 4583, "optimisticFMP": 4184, "pessimisticFMP": 4983, "roughEstimateOfTTI": 16150, "optimisticTTI": 15036, "pessimisticTTI": 17265, "roughEstimateOfSI": 6699, "optimisticSI": 983, "pessimisticSI": 8575, "roughEstimateOfLCP": 8899, "optimisticLCP": 8500, "pessimisticLCP": 9299}, | ||
| {"url": "https://www.mlb.com/", "roughEstimateOfFCP": 3186, "optimisticFCP": 3186, "pessimisticFCP": 3186, "roughEstimateOfFMP": 3186, "optimisticFMP": 3186, "pessimisticFMP": 3186, "roughEstimateOfTTI": 40427, "optimisticTTI": 32360, "pessimisticTTI": 48494, "roughEstimateOfSI": 19986, "optimisticSI": 1316, "pessimisticSI": 28299, "roughEstimateOfLCP": 4634, "optimisticLCP": 4312, "pessimisticLCP": 4956}, |
There was a problem hiding this comment.
Callout for update LCP values on this site
There was a problem hiding this comment.
Seems like a good test case for this since it's now roughEstimateOfLCP: 4634 while the "real" LCP was 9399.
Is the cause of the change an unfinished request and does it look reasonable to exclude it?
There was a problem hiding this comment.
Yes. This difference is from negative endTime requests.
This change doesn't make much difference on a new run of https://www.mlb.com.
I did notice a large drop in LCP time for a new run of https://mail.ru/ (11s -> 4s), but the LCP with DT throttling is ~2.4s so this seems reasonable.
connorjclark
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11856
Prior work #11870