tests: split smoke tests into one test per file #13461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
connorjclark
and removed request for
a team
brendankenny
commented
Dec 3, 2021
| */ | ||
| 'use strict'; | ||
|
|
||
| import a11y from './test-definitions/a11y.js'; |
There was a problem hiding this comment.
we could drop this file and have it just run all the files in test-definitions/ by default, similar to our *-test.js pattern for unit tests. It would need to be generated at build time for yarn build-smokehouse-bundle to replace it, though.
connorjclark
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delayed follow up to #12819
Finally splits the smoke tests into a single test per file. Each file exports its own test definition,
id,expectationsand optionalconfigandrunSerially. We discussed this a bit here and here.This PR is very big, but I've verified all the same tests and assertions are running before and after. Happy to break it up beyond the current smoke-slug-per-commit like it is.
The PR also breaks blame in a ton of places, but (I think) sets us up for much better blame going forward...e.g. with configs previously not tied to a particular test, it's difficult to see if a certain setting is required for all of the tests using that config or just one, and the other tests happened to work with the updated config so weren't changed.
There do seem to be a few places places where configs were overly complicated for most of the tests running against them (e.g. the smoke perf-config sets budgets for all the perf tests even though only one asserts them), but I left them unaltered for now.