deps: bump eslint and related items #13484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "eslint-plugin-local-rules": "0.1.0", | ||
| "eslint": "^8.4.1", | ||
| "eslint-config-google": "^0.14.0", | ||
| "eslint-formatter-codeframe": "^7.32.1", |
There was a problem hiding this comment.
we have it configured so the codeframe formatter is used in CI so if it fails there we see exactly what the prob is in the logs.
i also prefer using it locally.
in latest eslint they extracted the formatter so its not shipped in the main pkg anymore.
adamraine
reviewed
Dec 10, 2021
Comment on lines
201
to
202
| const serverResponseTimePercentage = | ||
| SERVER_RESPONSE_PERCENTAGE_OF_TTFB[record.resourceType] || DEFAULT_SERVER_RESPONSE_PERCENTAGE; |
There was a problem hiding this comment.
Suggested change
| const serverResponseTimePercentage = | |
| SERVER_RESPONSE_PERCENTAGE_OF_TTFB[record.resourceType] || DEFAULT_SERVER_RESPONSE_PERCENTAGE; | |
| const serverResponseTimePercentage = | |
| SERVER_RESPONSE_PERCENTAGE_OF_TTFB[record.resourceType] || DEFAULT_SERVER_RESPONSE_PERCENTAGE; |
There was a problem hiding this comment.
heh yeah i had touched this one manually but doing that change goes over 100chars :)
anyway, just added another break after the || to sort it, along with those indents.
paulirish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 4 commits each have a unique thing.