core(page-functions): set style in getOuterHTMLSnippet without violating CSP #13636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Feb 7, 2022
| @@ -10,7 +10,6 @@ import byteEfficiency from './test-definitions/byte-efficiency.js'; | |||
| import byteGzip from './test-definitions/byte-gzip.js'; | |||
| import cspAllowAll from './test-definitions/csp-allow-all.js'; | |||
| import cspBlockAll from './test-definitions/csp-block-all.js'; | |||
| import cspBlockAllM91 from './test-definitions/csp-block-all-m91.js'; | |||
There was a problem hiding this comment.
Drive-by, test isn't useful anymore
connorjclark
approved these changes
Feb 7, 2022
connorjclark
changed the title
paulirish
reviewed
Feb 7, 2022
| @@ -138,7 +138,17 @@ function getOuterHTMLSnippet(element, ignoreAttrs = [], snippetCharacterLimit = | |||
| dirty = true; | |||
| } | |||
|
|
|||
| if (dirty) clone.setAttribute(attributeName, attributeValue); | |||
| if (dirty) { | |||
| // Style attributes can be blocked by the CSP if they are set via `setAttribute`. | |||
There was a problem hiding this comment.
love finding those CSP holes :D
There was a problem hiding this comment.
IIRC constructable stylesheets are also not constrained by CSP but allow you to do the same stuff that is. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13630