core(fr): add logLevel to config context
#13681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Feb 18, 2022
| @@ -62,10 +62,10 @@ declare module Config { | |||
| * This information is typically set by the CLI or other channel integrations. | |||
| */ | |||
| interface FRContext { | |||
| gatherMode?: Gatherer.GatherMode; | |||
There was a problem hiding this comment.
drive-by: this shouldn't be exposed on the API. The first thing we do with it is force override with the correct value from whichever runner it's a parameter for.
| @@ -22,6 +23,8 @@ const {getBaseArtifacts, finalizeArtifacts} = require('./base-artifacts.js'); | |||
| */ | |||
| async function startTimespan(options) { | |||
| const {configContext = {}} = options; | |||
| log.setLevel(configContext.logLevel || 'error'); | |||
There was a problem hiding this comment.
Could move this into initializeConfig but it doesn't exactly fit. Running 3 different times isn't too big a deal anyway.
connorjclark
approved these changes
Feb 19, 2022
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13680