tests: use origin-agent-cluster to actually test oopifs #13777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Mar 23, 2022
| // All other scripts are filtered out because of our "OOPIF" filter (including anything | ||
| // that is just in another process, like a worker). | ||
| ScriptElements: [ | ||
| { | ||
| src: 'http://localhost:10200/simple-script.js', | ||
| source: 'network', | ||
| }, | ||
| { |
There was a problem hiding this comment.
shouldn't have ignored this in the original pr :)
…use into oopif-agent-cluster
adamraine
reviewed
Mar 31, 2022
| @@ -110,6 +110,8 @@ class Server { | |||
| // see https://github.com/jshttp/mime-types/issues/66 | |||
| if (contentType) headers['Content-Type'] = mime.contentType(contentType); | |||
|
|
|||
| headers['origin-agent-cluster'] = ['?1']; | |||
There was a problem hiding this comment.
Should we put this behind our own url parameter like isolated_frame or something? This is non-default behavior that we only use for one test.
If not could you add this to L103.
There was a problem hiding this comment.
couple reasons why I didn't put this behind a query param:
- chrome doesn't like it when you mix responses from the same origin with and without this header. I found I had to reset chrome to undo this "mix responses" state when navigating to these pages directly via
yarn static-server, which was pretty confusing - At least for me, I always assumed iframing across different ports on localhost would be isolated. Probably best if just isolate by default for our smoke tests.
adamraine
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://web.dev/origin-agent-cluster/