Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update to third-party-web 0.15.0 #13804

Merged
merged 2 commits into from
Apr 1, 2022
Merged

deps: update to third-party-web 0.15.0 #13804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b9a6fe
deps: update to third-party-web 0.15.0
connorjclark Mar 31, 2022
24f84f4
hmm
connorjclark Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/test/audits/third-party-summary-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('Third party summary', () => {
entity: {
text: 'Google Analytics',
type: 'link',
url: 'https://www.google.com/analytics/analytics/',
url: 'https://marketingplatform.google.com/about/analytics/',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patrickhulce/third-party-web#154

},
mainThreadTime: 95.15599999999999,
blockingTime: 0,
Expand Down
72 changes: 70 additions & 2 deletions lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8402,8 +8402,61 @@
"id": "third-party-summary",
"title": "Minimize third-party usage",
"description": "Third-party code can significantly impact load performance. Limit the number of redundant third-party providers and try to load third-party code after your page has primarily finished loading. [Learn more](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/loading-third-party-javascript/).",
"score": null,
"scoreDisplayMode": "notApplicable"
"score": 1,
"scoreDisplayMode": "binary",
"displayValue": "Third-party code blocked the main thread for 0 ms",
"details": {
"type": "table",
"headings": [
{
"key": "entity",
"itemType": "link",
"text": "Third-Party",
"subItemsHeading": {
"key": "url",
"itemType": "url"
}
},
{
"key": "transferSize",
"granularity": 1,
"itemType": "bytes",
"text": "Transfer Size",
"subItemsHeading": {
"key": "transferSize"
}
},
{
"key": "blockingTime",
"granularity": 1,
"itemType": "ms",
"text": "Main-Thread Blocking Time",
"subItemsHeading": {
"key": "blockingTime"
}
}
],
"items": [
{
"mainThreadTime": 0,
"blockingTime": 0,
"transferSize": 3888,
"entity": {
"type": "link",
"text": "Algolia",
"url": "https://www.algolia.com/"
},
"subItems": {
"type": "subitems",
"items": []
}
}
],
"summary": {
"wastedBytes": 3888,
"wastedMs": 0
}
}
},
"layout-shift-elements": {
"id": "layout-shift-elements",
Expand Down Expand Up @@ -10105,6 +10158,7 @@
],
"lighthouse-core/lib/i18n/i18n.js | columnTransferSize": [
"audits[resource-summary].details.headings[2].text",
"audits[third-party-summary].details.headings[1].text",
"audits[uses-long-cache-ttl].details.headings[2].text",
"audits[total-byte-weight].details.headings[1].text"
],
Expand Down Expand Up @@ -10141,6 +10195,20 @@
"lighthouse-core/audits/third-party-summary.js | description": [
"audits[third-party-summary].description"
],
"lighthouse-core/audits/third-party-summary.js | displayValue": [
{
"values": {
"timeInMs": 0
},
"path": "audits[third-party-summary].displayValue"
}
],
"lighthouse-core/audits/third-party-summary.js | columnThirdParty": [
"audits[third-party-summary].details.headings[0].text"
],
"lighthouse-core/lib/i18n/i18n.js | columnBlockingTime": [
"audits[third-party-summary].details.headings[2].text"
],
"lighthouse-core/audits/layout-shift-elements.js | title": [
"audits[layout-shift-elements].title"
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
"robots-parser": "^3.0.0",
"semver": "^5.3.0",
"speedline-core": "^1.4.3",
"third-party-web": "^0.12.7",
"third-party-web": "^0.15.0",
"ws": "^7.0.0",
"yargs": "^17.3.1",
"yargs-parser": "^21.0.0"
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7545,10 +7545,10 @@ text-table@^0.2.0:
resolved "https://registry.yarnpkg.com/text-table/-/text-table-0.2.0.tgz#7f5ee823ae805207c00af2df4a84ec3fcfa570b4"
integrity sha1-f17oI66AUgfACvLfSoTsP8+lcLQ=

third-party-web@^0.12.7:
version "0.12.7"
resolved "https://registry.yarnpkg.com/third-party-web/-/third-party-web-0.12.7.tgz#64445702379abf1a29066d636a965173e4e423c6"
integrity sha512-9d/OfjEOjyeOpnm4F9o0KSK6BI6ytvi9DINSB5h1+jdlCvQlhKpViMSxWpBN9WstdfDQ61BS6NxWqcPCuQCAJg==
third-party-web@^0.15.0:
version "0.15.0"
resolved "https://registry.yarnpkg.com/third-party-web/-/third-party-web-0.15.0.tgz#40790a6394233ecf1d0b8095abde3bfadde67338"
integrity sha512-kv+TVeppmasvDBXHfKCuQ4HNXapsyEXAGVANguzVDJ98xXm88ggtb9B09rVWvwDqapU5VZ4Q4JkCu2viyD/k0w==

throat@^6.0.1:
version "6.0.1"
Expand Down