core(fr): index test parity #13867
Merged
core(fr): index test parity #13867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@connorjclark friendly ping |
connorjclark
reviewed
Jun 8, 2022
connorjclark
approved these changes
Jun 11, 2022
| @@ -327,6 +327,7 @@ async function navigationGather(requestor, options) { | |||
| const artifacts = await Runner.gather( | |||
| async () => { | |||
| let {page} = options; | |||
| const normalizedRequestor = isCallback ? requestor : URL.normalizeUrl(requestor); | |||
There was a problem hiding this comment.
hmm, is this change necessary? it isn't even used until far down.
There was a problem hiding this comment.
Yes, at least to match the legacy behavior. If the url is invalid, we should throw before attempting to connect to the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #13865
I never copied some of the index tests for the new FR runner. This would have caught a few differences between the legacy runner and FR runner including #13863.
This PR brings back those tests for the FR runner.