Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(ci): add node 18 to test matrix #13874

Merged
merged 4 commits into from
Sep 20, 2022
Merged

tests(ci): add node 18 to test matrix #13874

merged 4 commits into from
Sep 20, 2022

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark requested a review from a team as a code owner April 19, 2022 20:56
@connorjclark connorjclark requested review from adamraine and removed request for a team April 19, 2022 20:56
@connorjclark
Copy link
Collaborator Author

OOM 👀 https://github.com/GoogleChrome/lighthouse/runs/6085169057?check_suite_focus=true#step:14:360

@connorjclark
Copy link
Collaborator Author

Shrug, let's try again in a few months.

@brendankenny brendankenny mentioned this pull request May 17, 2022
Closed
@brendankenny brendankenny mentioned this pull request Sep 1, 2022
Closed
@connorjclark connorjclark reopened this Sep 19, 2022
@connorjclark
Copy link
Collaborator Author

it passed 👀

@connorjclark connorjclark merged commit a2cb8dc into master Sep 20, 2022
@connorjclark connorjclark deleted the node-18 branch September 20, 2022 19:15
@kevinsamoei kevinsamoei mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@connorjclark @adamraine @devtools-bot