Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(css-usage): fetch stylesheet contents immediately after discovery #13887

Merged
merged 7 commits into from
May 9, 2022

Conversation

adamraine
Copy link
Member

Fixes #13882

Dropping stylesheets on CSS.styleSheetRemoved doesn't seem to protect us from "sheet not found" errors.

Even if they did protect us, a big stylesheet could negatively impact performance and be removed later on during the run. I think it's better to include any stylesheet that's added during a timespan and fetch the contents in parallel. Should we be concerned about performance since we have runInSeriesOrParallel for scripts?

This change shouldn't impact navigation/snapshot modes since they collect stylesheets at a point in time.

@adamraine adamraine requested a review from a team as a code owner April 21, 2022 01:13
@adamraine adamraine requested review from connorjclark and removed request for a team April 21, 2022 01:13
@connorjclark
Copy link
Collaborator

last thing: the commit title isn't accurate, can you revise? it was already fetching in parallel before (L96 of old code).

@adamraine adamraine changed the title core(css-usage): fetch stylesheet contents in parallel core(css-usage): fetch stylesheet contents immediately after discovery May 9, 2022
@adamraine adamraine merged commit 1e567c2 into master May 9, 2022
@adamraine adamraine deleted the css-usage-parallel branch May 9, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSSUsage errors on cross-origin navigation in timespan mode
3 participants