core(css-usage): fetch stylesheet contents immediately after discovery #13887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
May 6, 2022
connorjclark
reviewed
May 6, 2022
connorjclark
reviewed
May 6, 2022
lighthouse-core/test/fraggle-rock/scenarios/cross-origin-test-pptr.js
Outdated
Show resolved
Hide resolved
connorjclark
approved these changes
May 9, 2022
|
last thing: the commit title isn't accurate, can you revise? it was already fetching in parallel before (L96 of old code). |
adamraine
changed the title
connorjclark
pushed a commit
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13882
Dropping stylesheets on
CSS.styleSheetRemoveddoesn't seem to protect us from "sheet not found" errors.Even if they did protect us, a big stylesheet could negatively impact performance and be removed later on during the run. I think it's better to include any stylesheet that's added during a timespan and fetch the contents in parallel. Should we be concerned about performance since we have
runInSeriesOrParallelfor scripts?This change shouldn't impact navigation/snapshot modes since they collect stylesheets at a point in time.