Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smoke): remove old chrome version checks #13903

Merged
merged 1 commit into from
Apr 27, 2022
Merged

tests(smoke): remove old chrome version checks #13903

merged 1 commit into from
Apr 27, 2022

Conversation

connorjclark
Copy link
Collaborator

Fixes #13897

@connorjclark connorjclark requested a review from a team as a code owner April 25, 2022 20:14
@connorjclark connorjclark requested review from brendankenny and removed request for a team April 25, 2022 20:14
connorjclark
connorjclark commented Apr 25, 2022
View reviewed changes
lighthouse-cli/test/smokehouse/test-definitions/offline-sw-broken.js
// 0: {
// errorId: /warn-not-offline-capable/,
// },
0: {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still disabled (and there is a comment above providing context)

brendankenny
brendankenny approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@connorjclark connorjclark merged commit f86e60d into master Apr 27, 2022
@connorjclark connorjclark deleted the rm-ver-checks-old branch April 27, 2022 00:09
connorjclark added a commit that referenced this pull request May 9, 2022
@connorjclark
tests(smoke): remove old chrome version checks (#13903)
4b93909
@connorjclark connorjclark mentioned this pull request May 9, 2022
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees

@brendankenny brendankenny

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove stale compat pruning in smoke tests
3 participants
@connorjclark @brendankenny @devtools-bot