report: hide disclaimer text in timespan #13931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Apr 27, 2022
| this.dom.safelySetHref(calculatorLink, this._getScoringCalculatorHref(category.auditRefs)); | ||
|
|
||
| // Only add the disclaimer with the score calculator link if the category was rendered with a score gauge. | ||
| if (element.querySelector('.lh-gauge__wrapper')) { |
There was a problem hiding this comment.
I used this as the condition because the disclaimer + calculator seem to be tied to the category gauge. It's easy to make this condition depend on gather mode if that would make more sense.
There was a problem hiding this comment.
yeah, I think the only downside is that it makes it a more indirect condition, but you're right that at least for now, it's exactly when we show a score gauge that we'd want this message
brendankenny
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13929