tests: update create-test-trace utility #13942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Apr 28, 2022
|
|
||
| return { | ||
| GatherContext: {gatherMode: 'navigation'}, | ||
| traces: {defaultPass: createTestTrace({traceEnd: 5000})}, | ||
| traces: {defaultPass: createTestTrace({frameUrl, traceEnd: 5000})}, |
There was a problem hiding this comment.
a few of these tests were accidentally relying on the fact that the redirects audit was only using navStart events for the redirect chain if they have a isLoadingMainFrame property, and create-test-trace wasn't setting that property. The generated navStart event now has that property and these tests now set the navStart documentLoaderURL properly
| @@ -298,7 +298,7 @@ describe('Metrics: CLS', () => { | |||
|
|
|||
| it('ignores layout shift data from other tabs', async () => { | |||
| const trace = createTestTrace({timeOrigin: 0, traceEnd: 2000}); | |||
| const mainFrame = trace.traceEvents[0].args.frame; | |||
| const mainFrame = trace.traceEvents.find(e => e.name === 'navigationStart').args.frame; | |||
There was a problem hiding this comment.
these mainFrame changes are a little awkward (and one reason why we should consider an ease of use refactor at some point), but still straightforward. navStart isn't necessarily the first event.
| tid, | ||
| ph: 'I', | ||
| cat: 'disabled-by-default-devtools.timeline', | ||
| args: { | ||
| data: { | ||
| frameTreeNodeId: 6, | ||
| persistentIds: true, | ||
| frames: [{frame: rootFrame, url: frameUrl, name: '', processId: pid}], | ||
| frames: [{frame: rootFrame, url: 'about:blank', name: '', processId: pid}], |
There was a problem hiding this comment.
now defintely a navigation trace. we could adjust that if needed at some point
adamraine
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #13917 I noticed
create-test-tracehas some very outdated details and wanted to fix them before it all paged out of my brain. There's a much nicer and powerful API possible here, but this PR is just some surface-level fixes to get the generated test traces closer to real traces.