Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore when the which command fails #1395

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Ignore when the which command fails #1395

merged 1 commit into from
Jan 4, 2017

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented Jan 4, 2017

Experimenting with running lighthouse on https://hub.docker.com/r/justinribeiro/chrome-headless/
Running into a few issues.

brendankenny
brendankenny approved these changes Jan 4, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@brendankenny brendankenny merged commit da4a6df into GoogleChrome:master Jan 4, 2017
@Janpot Janpot deleted the which-cmd-failing branch January 4, 2017 23:15
andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
@Janpot @andrewrota
Ignore which failures when looking for Linux Chrome executable (Goo…
3cb4733 
…gleChrome#1395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Janpot @brendankenny