core(trace): add PrePaint event, renamed from UpdateLayerTree #13950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
May 4, 2022
paulirish
approved these changes
May 4, 2022
Co-authored-by: Paul Irish <paulirish@users.noreply.github.com>
|
I wish we had a test that had to change for this, but I assume tests for our various audits with grouped tasks don't have big enough Maybe we should look into a smoke test in the future that tries to exercise as many RenderingNG stages as possible? I don't have a good idea of how feasible that actually is. |
brendankenny
approved these changes
May 5, 2022
There was a problem hiding this comment.
@connorjclark hope you weren't waiting on me with two other approvals :) LGTM
connorjclark
changed the title
connorjclark
added a commit
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M102 will rename UpdateLayerTree to PrePaint. See https://chromium-review.googlesource.com/c/chromium/src/+/3519012
Trace data is the same.