tests(ci): shard all smoke tests #13968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
May 5, 2022
brendankenny
reviewed
May 5, 2022
| @@ -105,8 +110,17 @@ jobs: | |||
| path: .tmp/smokehouse-ci-failures/ | |||
|
|
|||
| smoke-fr: | |||
| strategy: | |||
| matrix: | |||
| smoke-test-shard: [1, 2, 3] | |||
There was a problem hiding this comment.
Three shards for all of these is getting a bit excessive (that list gets realllllly long) since we're not bottle necked on them. Should we use 2 for everything? After #13943 they should still be quite snappy
There was a problem hiding this comment.
only reason I did 3 was to slightly help the "re run failures because flaky test" use case.
although... maybe we could write to the job cache what smokes failed...then only re-run the failures on retries... same problem, better solution than "split it up more"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sharding to the FR, bundled and windows smoke tests. This should further reduce the headache of re-running flaky tests, and speed things up a bit.