core: extract BootupTime task summary methods #13971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
May 6, 2022
| return MainThreadTasks.getMainThreadTasks(mainThreadEvents, frames, timestamps.traceEnd); | ||
| } | ||
|
|
||
| describe('Task Summaries', () => { |
There was a problem hiding this comment.
these functions are quite well tested by the existing BootupTime et al tests, but only as integrated into the audit results, no unit tests, so it seemed appropriate to give some basic coverage since they're often used as units.
connorjclark
approved these changes
May 6, 2022
| it('returns the script URLs from a set of network records', () => { | ||
| const records = NetworkRecorder.recordsFromLogs(ampDevtoolsLog); | ||
| const urls = getJavaScriptURLs(records); | ||
| expect(urls.size).toEqual(13); |
There was a problem hiding this comment.
nit: when the size of an array changes it creates very unhelpful test failures messages. maybe just move this length check to after the for loop... or change toMatch to check an array in one-go?
There was a problem hiding this comment.
SG. It shouldn't ever change (until the trace does) but it would be more helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #13916
The responsiveness debugging audit will be the fourth audit using these functions, so it's just about time we spin them off into their own file.
They're not quite
main-thread-taskfunctions, nor are they just abouttask-groups, so a new file seemed appropriate. I'm not attached to their new location, however, so I'm happy to bikeshed.