core(responsiveness): add better INP fallback for old Chrome versions #13985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
May 10, 2022
| */ | ||
| static findInteractionEvent(responsivenessEvent, {traceEvents}) { | ||
| const candidates = traceEvents.filter(/** @return {evt is EventTimingEvent} */ evt => { | ||
| // Examine only beginning/instant EventTiming events. | ||
| return evt.name === 'EventTiming' && evt.ph !== 'e'; | ||
| }); | ||
|
|
||
| if (candidates.length && !candidates[0].args.data.frame) { | ||
| if (candidates.length && !candidates.some(candidate => candidate.args.data?.frame)) { |
There was a problem hiding this comment.
this should handle the seemingly impossible situation @paulirish was in, a newer Chrome but throwing at this point. AFAIK all EventTiming 'b' and 'n' events should have this format, but it's possible some somehow don't (empty string frame, maybe?).
Instead we just assert at least one candidate could (possibly) pass the frame equality check below.
brendankenny
commented
May 10, 2022
| "score": null, | ||
| "scoreDisplayMode": "error", | ||
| "errorMessage": "This version of Chrome is too old to support 'detailed EventTiming trace events'. Use a newer version to see full results." | ||
| "score": 1, |
There was a problem hiding this comment.
bonus: this works again without the trace update :)
connorjclark
changed the title
| @@ -215,6 +216,13 @@ class WorkDuringInteraction extends Audit { | |||
| if (interactionEvent === null) { | |||
| return {score: null, notApplicable: true}; | |||
| } | |||
| // TODO: remove workaround once 103.0.5052.0 is sufficiently released. | |||
There was a problem hiding this comment.
Can you make an issue and tag 10.0?
There was a problem hiding this comment.
Can you make an issue and tag 10.0?
yes, but would it be more like 10.2 or something?
connorjclark
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #13916
This change makes INP not error in Chrome < 103.0.5052.0, since it needs just the latency duration, not the rest of the new timing information. It's fine to assume that this audit will land in a DevTools after that version, but puppeteer user flows could easily run on older versions than that.
The work-during-interaction audit will still error, however, since it requires the new timing information.