Remove unused deps from extension.

[samccone]

Fixes #110

The real slowness here can be primarily blamed on npm3 not on any single dep.. soo until other things are finally resolved this is just the reality that we will have to deal with.

[brendankenny]

➡️🐘⬅️

[boopathi]

The following devDependencies from extension/ can be removed as well. These will be resolved anyway from the parent_directory/node_modules.

• gulp
• eslint-config-google
• and others if I've missed

basically not having duplicates in lighthouse/node_modules and lighthouse/extension/node_modules explicitly.

[boopathi]

And since all of them are devDeps, maybe avoid declaring them in extension/package.json and declare everything in lighthouse/package.json ? - This can reduce to one time npm install from the project root.

The only problem could be the following and do we require support for this ?

npm install lighthouse-extension
npm run build

[samccone]

Hey @boopathi, thanks for the insight! Let me provide you with some of the motivations for the current structure.

So the idea is that someone can work on the extension in isolation from the main code. Think of it as a sub project within the main project. By requiring an isolated set of dependencies and no shared knowledge of each other from the parent or the child this sub project keeps its isolation. So depending on the parent for npm deps would violate this principle and actually make the install process slower for everyone since if we bubbled up all the deps to the parent everyone would have to install them to work on the project, vs the current situation where a user has to only install these deps when they are working on the extension.

[paulirish]

the babel task doesnt change at all?

[samccone]

nope! since we are using gulp-babel we are all set

[samccone]

done

[boopathi]

@samccone But, for build or watch in extension/, you require files from parent which requires dependencies from parent anyways. So you'd have to run npm install on lighthouse/ before building lighthouse/extension