Exclude artifacts from result handed to extension/devtools. #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
reviewed
Jan 4, 2017
| @@ -172,6 +185,7 @@ window.createReportPageAsBlob = function(results, reportContext) { | |||
| let html; | |||
| try { | |||
| html = reportGenerator.generateHTML(results, reportContext); | |||
| throw new Error('sdlfjksdf'); | |||
brendankenny
reviewed
Jan 4, 2017
| @@ -30,6 +30,7 @@ const _flatten = arr => [].concat(...arr); | |||
|
|
|||
| let lighthouseIsRunning = false; | |||
| let latestStatusLog = []; | |||
| let latestArtifacts = undefined; | |||
There was a problem hiding this comment.
whats the lifecycle for this like for devtools and the extension? Is memory eventually cleared? The artifacts can be really big
There was a problem hiding this comment.
unknown. :)
I'll nuke it until we have an immediate need for it.
|
ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup from #1163
I was getting this guy:
artifacts.networkRecordsFWIW. All other artifacts are safe.reportExceptionto be ourjson-stringify-safefor good defense.Introduced awindow.getLatestArtifactsfor future use by devtools, and probably the viewer/perf-server (Return artifacts from runner and move assets/artifacts saving to cli #1163).R=@brendankenny, @WeiweiAtGit