-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clients(lr): expose listenForStatus #14024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
@@ -68,6 +68,7 @@ function setUpWorkerConnection(port) { | |||
/** @param {(status: [string, string, string]) => void} listenCallback */ | |||
function listenForStatus(listenCallback) { | |||
log.events.addListener('status', listenCallback); | |||
log.events.addListener('warning', listenCallback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume warnings are rare and this doesn't make things too chatty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah they're very rare. status
is definitely the chatty one.
@exterkamp'll need this for shuttling log messages across components