misc(build): fix lightrider report generator bundle #14031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
May 19, 2022
| @@ -35,17 +35,22 @@ async function buildReportGenerator() { | |||
| [`${LH_ROOT}/report/generator/flow-report-assets.js`]: 'export default {}', | |||
| }), | |||
| rollupPlugins.commonjs(), | |||
| rollupPlugins.nodeResolve(), | |||
There was a problem hiding this comment.
this just wasn't necessary
connorjclark
commented
May 19, 2022
| // adds a `require('fs')` when used above, which errors in google3 build. | ||
| const outPath = `${LH_ROOT}/dist/lightrider/report-generator-bundle.js`; | ||
| fs.writeFileSync(outPath, | ||
| fs.readFileSync(outPath, 'utf-8') + '\nwindow.ReportGenerator = ReportGenerator;\n'); |
brendankenny
reviewed
Jun 7, 2022
Comment on lines
+49
to
+50
| // Typically one would use `umd` to export to the window object, but for some reason rollup | ||
| // adds a `require('fs')` when used above, which errors in google3 build. |
There was a problem hiding this comment.
why don't we just shim fs like we do for the standalone report?
oh I'm too late :)
adamraine
pushed a commit
that referenced
this pull request
Jun 7, 2022
connorjclark
added a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed working in the LR demo app.
Originally changed to rollup in #13416, but apparently never tested.