Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove extending es6 class from url-shim to support es5 transpilation #1407

Merged
merged 1 commit into from
Jan 5, 2017
Merged

fix: remove extending es6 class from url-shim to support es5 transpilation #1407

merged 1 commit into from
Jan 5, 2017

Conversation

patrickhulce
Copy link
Collaborator

No description provided.

ebidel
ebidel approved these changes Jan 5, 2017
View reviewed changes
Copy link
Contributor

@ebidel ebidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read my mind :) I tested a similar version locally and it seems to do the trick.

@ebidel
Copy link
Contributor

ebidel commented Jan 5, 2017

Verified this fixes the issue. Waiting on the CI

@paulirish
Copy link
Member

sgtm

@ebidel ebidel changed the title fix: remove es6 class from url-shim fix: remove extendig es6 class from url-shim to support es5 transpilation Jan 5, 2017
@patrickhulce patrickhulce changed the title fix: remove extendig es6 class from url-shim to support es5 transpilation fix: remove extending es6 class from url-shim to support es5 transpilation Jan 5, 2017
@brendankenny brendankenny merged commit b03b0db into master Jan 5, 2017
@brendankenny brendankenny deleted the es6_url_fix branch January 5, 2017 01:52
@brendankenny
Copy link
Member

:(

andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
@patrickhulce @andrewrota
fix: don't extend URL in url-shim to support es5 transpilation (Googl…
3656960 
…eChrome#1407)
@brendankenny brendankenny mentioned this pull request Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebidel ebidel ebidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@patrickhulce @ebidel @paulirish @brendankenny