misc: fix broken links in changelog #14130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use <https://github.com/GoogleChrome/lighthouse/compare/> for "Full Changelog", instead of <https://github.com/compare/>.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
adamraine
approved these changes
Jun 15, 2022
|
@takenspc please sign the CLA |
This comment was marked as spam.
This comment was marked as spam.
adamraine
changed the title
| [Full Changelog]({{~@root.repoUrl}}/compare/{{previousTag}}...{{currentTag}}) | ||
| [Full Changelog]( | ||
| {{~#if @root.host}}{{~@root.host}}/{{/if~}} | ||
| {{~#if @root.owner ~}}{{@root.owner}}/{{/if~}} |
There was a problem hiding this comment.
do all these newlines work? yarn changelog
There was a problem hiding this comment.
Looked fine when I tried it:
<a name="9.5.0"></a>
# 9.5.0 (2022-06-15)
[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v7.3.0...v9.5.0)
~~ TODO: https://chromiumdash.appspot.com/schedule ~~
We expect this release to ship in the DevTools of [Chrome XX](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks.
## Notable Changes
~~ TODO: Move notable changes here ~~
## New Audits
* add work-during-interaction diagnostic ([#13982](https://github.com/GoogleChrome/lighthouse/pull/13982))
* add responsiveness metric for timespans ([#13917](https://github.com/GoogleChrome/lighthouse/pull/13917))
* lcp-lazy-loaded ([#12838](https://github.com/GoogleChrome/lighthouse/pull/12838))
* fr: uses-responsive-images-snapshot ([#12714](https://github.com/GoogleChrome/lighthouse/pull/12714))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"Full Changelog" links of changelogs are broken since v9.3.0.
Expected urls are
https://github.com/GoogleChrome/lighthouse/compare/v1...v2though actual urls arehttps://github.com/compare/v1..v2.I guess that updating
conventional-changelog-clicause this issue.This PR fixes changelog template to genearete correct urls and broken links of changelog.md.
Related Issues/PRs
This issue seems trivial and fix is straightforward so I skipped creating an issue. Let me know if I should create an issue.