core(network-requests): add frame and preload debug data #14161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Jun 27, 2022
| (min, record) => Math.min(min, record.startTime), | ||
| Infinity | ||
| ); | ||
| const records = await NetworkRecords.request(devtoolsLog, context); |
There was a problem hiding this comment.
switching to await causes a lot more noise here (sorry, much easier to review with ?w=1), but adding MainResource required this to be either async, a promise chain, or Promise.all, so it was much easier to bite the bullet and drag this code out of 2018.
| const TCPMs = record.lrStatistics?.TCPMs; | ||
| const requestMs = record.lrStatistics?.requestMs; | ||
| const responseMs = record.lrStatistics?.responseMs; | ||
| // Default these to undefined so omitted from JSON in the negative case. |
There was a problem hiding this comment.
we really don't need a ton of isLinkPreload: false in all our LHRs, so seemed better to map false to undefined so the property is just dropped when the LHR is JSON.stringify()ed.
Comment on lines
+61
to
+63
| const experimentalFromMainFrame = mainFrameId ? | ||
| ((record.frameId === mainFrameId) || undefined) : | ||
| undefined; |
There was a problem hiding this comment.
really need a reverse ??, returning undefined if the value on the left is undefined :) Alternatives welcome
connorjclark
approved these changes
Jun 27, 2022
brendankenny
added a commit
that referenced
this pull request
Jun 27, 2022
brendankenny
added a commit
that referenced
this pull request
Jun 28, 2022
brendankenny
added a commit
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #14155, this PR fills in some missing pieces of debugData to make it easier to analyze LCP issues in HTTP Archive data.
Adds two new optional properties to the
network-requestshidden audit:isLinkPreloadexperimentalFromMainFrame(navigations only)The second one is just if the request came from the main frame or not, but it turns out there's not really any way to do that in a
timespanright now. We have network request frame information, but we don't have information on the main frame, and it's not even "the main frame" singular, since the frame will change if the timespan contains navigations :)Since HTTP Archive only includes navigation runs, I decided to defer the general navigation/timespan solution to the already-in-discussion request source/target idea in #14157, and call it
experimentalFromMainFrameso it's slightly more clear that the property might not be around in a few releases. Happy to bikeshed on the name, implementation, etc.