Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(devtools): remove webtests, sync e2e tests, use release mode #14163

Merged
merged 16 commits into from
Jul 7, 2022

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jun 27, 2022

We can remove these tests now, because we're starting to migrate to e2e tests (#14110). Pretty sure the devtools smoke tests will cover things just as well in the interim, but we can consider 10.0 blocking on the e2e migration.

  • Removes webtests CI job and associated files
  • Move all of chromium-web-tests to devtools-tests
  • Except for blink_tools and content_shell, no longer need that

@connorjclark connorjclark requested a review from a team as a code owner June 27, 2022 19:36
@connorjclark connorjclark requested review from brendankenny and removed request for a team June 27, 2022 19:36
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some version of https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3721466 will fix the problem, and we already made these tests optional for merging PRs. Is there an urgent reason to remove these tests?

@connorjclark
Copy link
Collaborator Author

We're committed to dropping these tests, have already started porting a couple, and won't do another CDT release before that process finishes. No need to continue playing the whack-a-mole game anymore. They'll still be in the CDT frontend for now, in case they catch something important.

@adamraine
Copy link
Member

They'll still be in the CDT frontend for now, in case they catch something important.

I'm not so sure, it seems like our web tests are non-fatal in DT frontend. They didn't catch the issue in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3721466 before it happened. I guess that makes us the only place the tests "matter"?

Since we're not doing another release until it's done I'm fine with merging this, but it seems like https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3721466 could buy us a few more weeks of use instead of creating a blind spot in our tests for a few weeks.

@connorjclark connorjclark changed the title tests(devtools): remove webtests tests(devtools): remove webtests and sync e2e tests Jul 6, 2022
@connorjclark connorjclark changed the title tests(devtools): remove webtests and sync e2e tests tests(devtools): remove webtests, sync e2e tests, use release mode Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants