tests: use workers, Mocha node api instead of calling the CLI #14215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jul 15, 2022
| import {Connection} from '../../gather/connections/connection.js'; | ||
| import {fnAny, mockCommands} from '../test-utils.js'; | ||
|
|
||
| const {createMockSendCommandFn} = mockCommands; | ||
|
|
||
| // Some imports needs to be done dynamically, so that their dependencies will be mocked. |
There was a problem hiding this comment.
this was 100% unnecessary, and actually triggers a bug in testdouble I'm in the middle of fixing
adamraine
reviewed
Jul 18, 2022
|
|
||
| for (const test of testsToRunIsolated) { | ||
| console.log(`Running test in isolation: ${test}`); | ||
| const worker = new Worker(new URL(import.meta.url), { |
There was a problem hiding this comment.
Why does this need a new URL?
There was a problem hiding this comment.
Because urls and esm module paths are maddeningly incompatible... even with itself.
adamraine
approved these changes
Jul 18, 2022
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the annoyances of Windows shell usage go away.
Also a first step for injecting our own "setup" scripts before certain tests, to make mocking ES modules simpler to write / less error prone. That requires full control on when modules are evaluated, which this PR gives us.