new_audit: paste-preventing-inputs

[connorjclark]

Removes password-inputs-can-be-pasted-into and adds a more generic paste-preventing-inputs audit.

[connorjclark]

@adamraine how should I update these FR sample artifacts? We may need a script to do this (like we have for legacy runner)

[adamraine]

yarn update:flow-sample-json --rebaseline-artifacts Inputs

[connorjclark]

hmmm

[adamraine]

Yeah maybe the script needs updating/hardening for this specific use case, but the structure is already there.

[connorjclark]

@adamraine are these expected changes? From running update on just Inputs.

[adamraine]

Hmm looks like a bug in update-flow-fixtures.js. Timing should only update if you specify it.

I'll look into it but we can probably still include it in this PR since that's the artifact we would be storing.

[adamraine]

Never mind, I think this is expected. loadArtifacts adds it when we pull the artifacts from disk:

lighthouse/core/lib/asset-saver.js

Lines 88 to 90 in e154f3d

	// Any Timing entries in saved artifacts will have a different timeOrigin than the auditing phase
	// The `gather` prop is read later in generate-timing-trace and they're added to a separate track of trace events
	artifacts.Timing.forEach(entry => (entry.gather = true));

I think it makes sense to keep.

[connorjclark]

Asked ChatGPT what it thinks we should name the audit...

Lighthouse is a website audit tool comprised of many audits. Audits have an id, which ideally follow these rules:

- The audit ID should be kebal-case.
- The audit ID should be based on the noun of the subject matter that it surfaces to the user
- No verbs.
- No `no-` prefixes.
- Use the noun of the items it surfaces or concept it centers around.
- Adjective modifiers are acceptable and encouraged if the noun would be too broad without specificty.
- If an adjective modifier will result in describing either the passing or failing state, prefer the failing state.

A new audit is being developed that fails if there are any input elements on the page that prevent the user from pasting the contents
of their clipboard. This behavior results in poor user experiences, because it can be frustrating to not be able to quickly insert text. Most commonly, it makes using password managers cumbersome. But it can make any type of input harder to use, such as pasting an address.

Please give some suggestions for a good id for this new audit.

Response:

1. clipboard-pasting
2. pasteability
3. clipboard-paste-blocking
4. paste-prevention
5. clipboard-usage
6. copy-paste-accessibility

[patrickhulce]

ooooo, pasteability, look at chatgpt go :D

[connorjclark]

sorry chatgpt but we went with paste-preventing-inputs. you didn't account for the second item in our list of rules, shame