Isolate use of json-stringify-safe. #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
approved these changes
Jan 7, 2017
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| const fs = require('fs'); | |||
| const log = require('../../lighthouse-core/lib/log.js'); | |||
| // The networkRecords artifacts have circular references | |||
There was a problem hiding this comment.
I would add this comment next to the single usage so we know why that one is different.
paulirish
force-pushed
the
strngifysafe
branch
from
2fddf48
to
0bb1742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our data structures do not have circular references, with the exception of networkRecords.
json-stringify-safe was added (by me) to the report generator, however it's unnecessary there.
Additionally, the devtools minifier attempted to minify
json-stringify-safeand had trouble with the semi-colon-less code style. (Yes, the devtools' minifier is lame, but oh well).👷