Guard against launching multiple Chrome processes #1436
Conversation
|
LGTM 😄 just a question when did you have this issue? ^^ |
|
@wardpeet Not in lighthouse. Subclassing this ChromeLauncher in my own code. Got this issue because I assumed |
| @@ -136,6 +136,11 @@ class ChromeLauncher { | |||
|
|
|||
| spawn(execPath: string): Promise<any[]> { | |||
| return new Promise((resolve, reject) => { | |||
| if (this.chrome) { | |||
| log.verbose('ChromeLauncher', `Chrome already running with pid ${this.chrome.pid}.`); | |||
There was a problem hiding this comment.
maybe use log.warn? Seems like an unusual situation that in most cases you'd want to know your use of launcher is trying to launch chrome twice
There was a problem hiding this comment.
(the tradeoff being that it adds warning noise to a use case like your own. A compromise might be just log.log)
There was a problem hiding this comment.
It's all the same for me, I just took whatever was underneath. Just let me know what you prefer
|
@brendankenny Changed to |
* Guard against launching multiple Chrome processes * Change verbosity
No description provided.