Refactor console special characters

[maciej-ka]

Gather definitions of colors and special characters in log.js.

Closes: #1414

[wardpeet]

just a question about constants

[wardpeet]

Any reason why you don't make this constants? They don't need to be on the class.

[maciej-ka]

Having them in class doesn't require excessive import statements like import {green, red, bold ... . I don't mind changing this if you prefer named exports for each of those.

[wardpeet]

no not exports :)

but not my call to make so waiting for the rest of the team to give final feedback

const red = '\x1B[31m';
const reset = '\x1B[0m';

class Log {
...
static redify(str) {
  return `${red}${str}${reset}`;
}
module.exports = Log;

[XhmikosR]

👍 for @wardpeet's approach.

[maciej-ka]

I agree that would be the best, but definitions (of tick, yellow and other) are used outside this module for example in print.ts so I guess it has to go into export somehow.

[maciej-ka]

btw. that was the whole point of this issue: to cut duplications.

[XhmikosR]

Hmm, indeed that's a fair point.

So, it's the decision of either class or exports.

[ebidel]

I like the idea of using language constructs (static getters).

[maciej-ka]

@ebidel, right something like:

class Log {
   static get green() { return '\x1B[32m'; }
}

I'll send a commit.

[XhmikosR]

@Lokson: thanks for this, I had started doing it locally so this saved me some time :)

[maciej-ka]

@XhmikosR: welcome!

[brendankenny]

LGTM, though others can weigh in on inflicting my greenify() and redify() functions on code outside of smokehouse :)

[paulirish]

great stuff. :)

[paulirish]

👩‍🎨🎨