deps(puppeteer): upgrade to 18.0.3 #14398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
requested review from
brendankenny
and removed request for
a team
adamraine
commented
Sep 20, 2022
| @@ -173,7 +173,8 @@ describe('Lighthouse Viewer', () => { | |||
| }); | |||
|
|
|||
| it('should support swapping locales', async () => { | |||
| function queryLocaleState() { | |||
| async function queryLocaleState() { | |||
| await viewerPage.waitForSelector('.lh-locale-selector'); | |||
There was a problem hiding this comment.
I didn't figure out the exact cause, but I guess the next line was executed too quickly and .lh-locale-selector wasn't ready.
When I switched to headfull chrome this test started passing.
connorjclark
changed the title
|
Seems like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting out from #14385