core(fps): limit height at max webp size #14499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
Nov 4, 2022
connorjclark
reviewed
Nov 4, 2022
connorjclark
reviewed
Nov 4, 2022
adamraine
commented
Nov 4, 2022
| metrics.contentSize.height / | ||
| metrics.layoutViewport.clientHeight | ||
| metrics.cssContentSize.height / | ||
| metrics.cssLayoutViewport.clientHeight |
There was a problem hiding this comment.
The old metrics are deprecated:
https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-getLayoutMetrics
connorjclark
reviewed
Nov 4, 2022
adamraine
changed the title
connorjclark
approved these changes
Nov 8, 2022
brendankenny
reviewed
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screenshot was returning an empty string for the data on https://theverge.com
We are not limited by the max texture size (16384 on my macbook; but this is unrelated to Page.captureScreenshot) but we are limited by the max web size of 16383