core(network-request): use ms instead of seconds #14567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
paulirish
approved these changes
Nov 29, 2022
| @@ -25,14 +25,14 @@ class NetworkNode extends BaseNode { | |||
| * @return {number} | |||
| */ | |||
| get startTime() { | |||
| return this._record.startTime * 1000 * 1000; | |||
| return this._record.startTime * 1000; | |||
There was a problem hiding this comment.
seems kinda awkward that the lantern depgraph and crc are still in seconds.
wdyt about changing both of those in here, too?
There was a problem hiding this comment.
I mentioned this in the other PR, but I would like to keep lantern changes in a separate PR. I expect it to change a number of things in a trivial way (snapshots, accuracy) due to the limits of floating point precision. It should be a quick change I can follow up with when this lands.
There was a problem hiding this comment.
maybe add some comments in network-node/base-node/cpu-node and crc that these times are in seconds?
and/or a TODO?
cuz right now its kinda impossible to tell from the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split out from #14311
Changes the network request (aka network records) start and end time properties to be in ms, instead of seconds. This should not impact any audit values -
network-requestswas already converted to msHowever
critical-request-chaintimings and startTime/endTime in lanternnodes remain as seconds. They'll be adjusted in a followup.