DBW: update smokehouse tests to do deep equals #1457
Conversation
There was a problem hiding this comment.
LGTM. Excited to have this checking in dbw_tester after all the work you've put in to test all these terrible corner cases :)
@paulirish @patrickhulce for a second opinion on this using a length property solution we came up with for checking array lengths. There is precedence (some things that take an array will actually take anything with a length property, e.g. the first parameter of Array.from()), but one weird thing is that we only check expected's own enumerable properties (via Object.keys), but currently allow the matching property on actual to be anywhere on the prototype chain (which is why checking length works).
Is that unexpected/confusing? The only other option seems to be finish adding function comparators to smokehouse and do a (actual) => actual.length === 10 for the expected values.
| @@ -345,6 +346,7 @@ | |||
| } | |||
| </script> | |||
|
|
|||
| <!-- PASS: not in header, does not block rendering --> | |||
There was a problem hiding this comment.
oh yeah actually could you comment that it's there to polyfill promise and make sure we don't break :)
|
not a huge fan of the nested length object compared to |
|
🚬 |
|
Trav, you're my boyyyyyyy. |
R: @brendankenny all