core(doctype): check for limited quirks mode #14576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
connorjclark
commented
Dec 1, 2022
adamraine
reviewed
Dec 1, 2022
| @@ -41,6 +43,7 @@ class Doctype extends Audit { | |||
| failureTitle: str_(UIStrings.failureTitle), | |||
| description: str_(UIStrings.description), | |||
| requiredArtifacts: ['Doctype'], | |||
| __internalOptionalArtifacts: ['InspectorIssues'], | |||
There was a problem hiding this comment.
If we're going to use this outside the experimental config, maybe drop the __internal?
There was a problem hiding this comment.
Not until FR does a better job re: scheduling. Also that's a bigger change :/
connorjclark
force-pushed
the
limited-quirks
branch
from
811ec89
to
5be976f
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
connorjclark
force-pushed
the
limited-quirks
branch
from
5be976f
to
e92e3e3
Compare
adamraine
approved these changes
Dec 6, 2022
adamraine
reviewed
Dec 6, 2022
| @@ -3299,10 +3299,11 @@ | |||
| }, | |||
| "doctype": { | |||
| "id": "doctype", | |||
| "title": "Page has the HTML doctype", | |||
| "title": "Page lacks the HTML doctype, thus triggering quirks-mode", | |||
There was a problem hiding this comment.
Looks like the doctype artifact is out of date on the flow artifacts:
yarn update:flow-sample-json --rebaseline-artifacts Doctype
adamraine
reviewed
Dec 6, 2022
| @@ -295067,7 +295067,8 @@ | |||
| "Doctype": { | |||
| "name": "html", | |||
| "publicId": "", | |||
| "systemId": "" | |||
| "systemId": "", | |||
| "documentCompatMode": "CSS1Compat" | |||
There was a problem hiding this comment.
This is only for one flow step, shouldn't there be more
2 navigations and a snapshot so 3 total
There was a problem hiding this comment.
I suppose! The update script didn't work so I just updated one thing 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14570
We can't determine limited-quirks-mode without doing a bunch of work ourselves; and the only protocol is via inspector issues which is not snapshot friendly but given this is a very minor edge case, it seems ok to use an optional artifact here. FR doesn't know how to schedule such artifacts, but the runner still passes to the audit when possible, so in the most common cases (not filtering to just doctype audit, or excluding all audits that require InspectorIssues) this should just work. And when it doesn't... whatever?
Without knowing for sure if something is no-quirks-mode, we will always pass the audit.