Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix eslint no-undef #1462

Merged
merged 3 commits into from
Jan 13, 2017
Merged

chore: fix eslint no-undef #1462

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d2cfec
chore: fix eslint no-undef
patrickhulce Jan 12, 2017
2d89a74
update to bring in all of eslint recommended
patrickhulce Jan 12, 2017
f886dc7
move to just oneline disable
patrickhulce Jan 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ module.exports = {
"env": {
"node": true
},
"globals": {
"Map": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these be false by default?

"Promise": false,
"Set": false
},
"rules": {
// 2 == error, 1 == warning, 0 == off
"indent": [2, 2, {
Expand All @@ -21,6 +26,7 @@ module.exports = {
"number": true,
"string": true
}],
"no-undef": 2,
"no-unused-expressions": [2, {
"allowShortCircuit": true,
"allowTernary": false
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/performance-experiment/report/injected-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

/* global window, document, location */
/* global window, document, location, fetch */

'use strict';

Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,7 @@ class Driver {
* @return {function(...*): *} A wrapper around the original function.
*/
function captureJSCallUsage(funcRef, set) {
/* global window */
const __nativeError = window.__nativeError || Error;
const originalFunc = funcRef;
const originalPrepareStackTrace = __nativeError.prepareStackTrace;
Expand Down