fix: less noisy CSS unused rules #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* filter out duplicate stylesheets * don't report stylesheets that have no rules addresses #1456
|
R: @ebidel FWIW, I still think flagging the sheets as duplicate is cleaner than not returning them at all, but I totally empathize with the unnecessary noisiness :) |
ebidel
suggested changes
Jan 13, 2017
| @@ -101,6 +101,15 @@ | |||
| font-size: 20px; | |||
| } | |||
| </style> | |||
|
|
|||
| <style> | |||
| /* Empty on purpose */ | |||
There was a problem hiding this comment.
/* PASS - Empty on purpose */
| </style> | ||
|
|
||
| <style> | ||
| /* Just an import shouldn't show up */ |
| @@ -127,7 +132,7 @@ class UnusedCSSRules extends Audit { | |||
| const unusedRatio = (unused / usage.length) || 0; | |||
| const results = Object.keys(indexedSheets).map(sheetId => { | |||
| return UnusedCSSRules.mapSheetToResult(indexedSheets[sheetId]); | |||
| }); | |||
| }).filter(Boolean); | |||
There was a problem hiding this comment.
Don't feel strongly about it, but .filter(n => n) would also filter out the falsey values.
There was a problem hiding this comment.
Yeah I guess this is a pattern I'm used to, but is there a reason we don't use Boolean anywhere? !! seems to be preferred for casting throughout.
|
As an example, here's a run from chromestatus.com. It has a bunch of duplicate sheets from shadow dom usage:
|
patrickhulce
force-pushed
the
css_rules_improvements
branch
from
7845b2c
to
af413d5
Compare
|
PTAL :) |
ebidel
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1456