Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(emulation): retire moto g4, use moto g power #14674

Merged
merged 11 commits into from Feb 4, 2023
Merged

core(emulation): retire moto g4, use moto g power #14674

merged 11 commits into from Feb 4, 2023

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jan 13, 2023 •
edited

ref #14256

@connorjclark connorjclark requested a review from a team as a code owner January 13, 2023 01:36
@connorjclark connorjclark requested review from brendankenny and removed request for a team January 13, 2023 01:36
@adamraine
Copy link
Member

We're also going to need to update DT settings when this is rolled since DT sets up emulation on it's own

@connorjclark connorjclark mentioned this pull request Jan 13, 2023
Closed
paulirish
paulirish reviewed Jan 13, 2023
View reviewed changes
core/config/constants.js Outdated Show resolved Hide resolved
adamraine
adamraine reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the user agent as well?

copybara-service bot pushed a commit to ChromeDevTools/devtools-frontend that referenced this pull request Feb 2, 2023
@adamraine
Add Moto G Power to emulated devices
24e50e4 
Lighthouse plans to use the Moto G Power as the default emulated device
for version 10.0. This will require the Moto G Power to be in the
emulated device list when running Lighthouse in DevTools.

Lighthouse PR:
GoogleChrome/lighthouse#14674

Bug: None
Change-Id: I2335bf8bc933b84fe13f85ea585ffb7e5c7ee506
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4214256
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
copybara-service bot pushed a commit to ChromeDevTools/devtools-frontend that referenced this pull request Feb 3, 2023
@adamraine
[lighthouse] Make Moto G Power the emulated mobile device
1427476 
This should accompany the release of Lighthouse 10.0 which switches the
default mobile device to the Moto G power.

Lighthouse PR:
GoogleChrome/lighthouse#14674

Bug: None
Change-Id: I84154e10181d9c02e32daa70893b7ff4ce5905aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4219345
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
adamraine
adamraine reviewed Feb 3, 2023
View reviewed changes
cli/test/smokehouse/test-definitions/dobetterweb.js
},
length: 1,
length: 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the new one, should we add an expectation for it now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unrelated, just so happened that the other audit being tested here got caught up. Don't wanna add it here...cuz it is named specific to its audit... :/

cli/test/smokehouse/test-definitions/fps-max.js Outdated Show resolved Hide resolved
core/test/fixtures/fraggle-rock/artifacts/step0/artifacts.json
@@ -163,12 +163,12 @@
"throttlingMethod": "simulate",
"screenEmulation": {
"mobile": true,
"width": 360,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good for this PR, but we should do another complete artifact refresh to capture any changes the screen adjustment had.

report/test/renderer/performance-category-renderer-test.js
@@ -160,7 +160,7 @@ describe('PerfCategoryRenderer', () => {
const oppElements = [...categoryDOM.querySelectorAll('.lh-audit--load-opportunity')];
expect(oppElements.map(e => e.id).sort()).toEqual(oppAudits.map(a => a.id).sort());
expect(oppElements.length).toBeGreaterThan(0);
expect(oppElements.length).toMatchInlineSnapshot('7');
expect(oppElements.length).toMatchInlineSnapshot('6');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the change here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure it was just image aspect ratio or responsive images no longer failing according to the artifacts.

@devtools-bot devtools-bot merged commit e1566c0 into main Feb 4, 2023
@devtools-bot devtools-bot deleted the moto-g-power branch February 4, 2023 01:07
@tkadlec tkadlec mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benschwarz benschwarz benschwarz left review comments

@paulirish paulirish paulirish left review comments

@adamraine adamraine adamraine approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny brendankenny is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@brendankenny brendankenny

Labels
10.0 waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@connorjclark @adamraine @benschwarz @paulirish @brendankenny @devtools-bot